Skip to content

docs(thirdweb): collapse seven thirdweb pages into one tool page at parity (#2255) - #2291

Merged
palango merged 3 commits into
mainfrom
GigaHierz/2255-thirdweb-one-page
Aug 28, 2026
Merged

docs(thirdweb): collapse seven thirdweb pages into one tool page at parity (#2255)#2291
palango merged 3 commits into
mainfrom
GigaHierz/2255-thirdweb-one-page

Conversation

@GigaHierz

Copy link
Copy Markdown
Contributor

Closes the code half of #2255.

What changed

thirdweb was documented across seven pages — three under Dev Environments (overview, thirdweb, one-click-deploy), an SDK page under Libraries & SDKs, and three orphaned pages under build-on-celo/build-with-thirdweb/ — with tutorials, step-by-step code, and wording no other tool gets ("Using Thirdweb is recommended because…", "Complete Web3 development framework with powerful wallet tools", "Recommended: Use affordable indexers like thirdweb Insight").

It is now one page: tooling/dev-environments/thirdweb, flat alongside foundry.mdx, hardhat.mdx and remix.mdx, same title pattern ("Deploy on Celo with thirdweb" / sidebar "Using thirdweb"). It carries only what these docs actually own — the Celo chain configuration — and points at thirdweb's own docs for the rest.

Resolving the ticket's OPEN question

OPEN: home it under dev-environments or under SDKs; pick one and apply the same choice to the redirects

Dev Environments. Foundry, Hardhat and Remix are single flat .mdx files in that group; a single page in its own folder next to them would not match. All seven old paths redirect to the one page.

De-promotion pass on the remaining mentions

Page Change
tooling/wallets/index.mdx Kept as a plain list item at parity with the other 10 providers; utm_source=celo&utm_medium=documentation&utm_campaign=chain_docs dropped (no other provider carries campaign parameters)
build-on-celo/build-with-ai/x402.mdx "Alternative: thirdweb facilitator" → "Other facilitators", one sentence and one link; the duplicate Playground row dropped from Resources
build-on-celo/scaling-your-app.mdx Indexer section no longer recommends a vendor; points at /tooling/indexers/overview
tooling/libraries-sdks/web3/index.mdx "Please consider using thirdweb or viem" → "Use viem instead"
tooling/nodes/overview.mdx Neutral one-line blurb, utm parameters dropped
build-on-celo/quickstart.mdx "Complete Web3 development framework with powerful wallet tools" → "Wallet connector from thirdweb"

Two unrelated bugs fixed while in these files

  • build-on-celo/attribution-tags.mdx:64 linked wagmi to /tooling/dev-environments/thirdweb/overview. Now points at wagmi.sh.
  • tooling/overview/index.mdx and tooling/dev-environments/index.mdx both listed /developer/deploy/* (stale redirect sources) and omitted Foundry. Both lists are now current root-relative paths, alphabetical, with Foundry added.

Three now-unreferenced images deleted (img/thirdweb.svg, img/thirdweb-explore.png, img/building/how-to-deploy/thirdweb/thirdweb-explore.png) — grep across *.mdx, *.json and *.jsx shows no remaining references.

On the redirect chain

The ticket flagged a chain at docs.json:1468/build/build-with-thirdweb/celo-nft-drop-tutorial, itself a redirect source. That dead end was already pruned by #2279. Verified on this branch — no thirdweb redirect resolves to another redirect source:

python3 -c "
import json;d=json.load(open('docs.json'))
srcs={r['source'] for r in d['redirects']}
print([r for r in d['redirects'] if 'thirdweb' in r['source']+r['destination'] and r['destination'] in srcs])
"
# []

Verification

$ npx mintlify broken-links
success no broken links found

$ bash scripts/check-orphans.sh
Found 20 orphan page(s) …

20, down from 23 — the three thirdweb orphans are gone. The remaining 20 are #2253's, and #2253 stacks on this branch so the orphan check can flip from report-only to gating in one step.

Not in this PR

The ops half of #2255 is untouched and the issue should stay open for it: the usage audit of which ecosystem projects still rely on thirdweb, notifying the top projects, and planning the vendor move. Nothing in this repo can answer that.

The thirdweb title pair from #2241 is resolved as a side effect — the colliding "Overview"/"Getting Started with Thirdweb" pages no longer exist.

@GigaHierz
GigaHierz requested review from a team as code owners August 28, 2026 08:09
@GigaHierz
GigaHierz requested review from karlb and palango and removed request for a team August 28, 2026 08:09

@palango palango left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the checks myself on this branch and they match the PR body: broken-links is green, the orphan count is down to 20 with the three thirdweb ones gone. All seven old paths reach the new page in one hop, and nothing in mdx/jsx still points at the deleted pages or images.

  1. The Celo Sepolia claim in the new page is wrong. tooling/dev-environments/thirdweb.mdx:13 says there's no named export for Celo Sepolia, but thirdweb@5.121.1 exports celoSepoliaTestnet from thirdweb/chains, chain ID 11142220. defineChain(11142220) does work, so nothing is broken today, but this page's whole job is the Celo chain config:

    import { celo, celoSepoliaTestnet } from "thirdweb/chains";
  2. Add a redirect for /tooling/libraries-sdks/thirdweb-sdk/index. Mintlify served the deleted page at that path too, and right now only the bare path is covered, so the /index variant will 404. docs.json already has 29 /index sources for this case.

  3. Not from this PR, no need to fix here: the mdx-code-block fence at tooling/dev-environments/index.mdx:29 is a Docusaurus/Crowdin leftover that Mintlify renders as a literal code block. You're editing right below it anyway, so feel free to drop the fence, or leave it for a cleanup pass.

@GigaHierz

Copy link
Copy Markdown
Contributor Author

All three addressed in 6c3fb63e.

1. The Celo Sepolia claim was wrong. Confirmed against the published package rather than taking it on trust:

$ npm view thirdweb version
5.121.1
$ cat package/dist/esm/chains/chain-definitions/celo-sepolia-testnet.js
export const celoSepoliaTestnet = defineChain({
  id: 11142220,
  name: "Celo Sepolia Testnet",
  nativeCurrency: { decimals: 18, name: "CELO", symbol: "CELO-S" },
  blockExplorers: [{ name: "Celo Sepolia Explorer", url: "https://celo-sepolia.blockscout.com/" }],
  testnet: true,
});

dist/types/exports/chains.d.ts:24 re-exports it. The block now uses the named export for both networks and drops defineChain entirely — which also makes the snippet shorter, since the whole point of the page is the chain config.

2. /index redirect added. You are right that only the bare path was covered; the /index variant would have 404d. Added directly below the bare source.

3. Fence dropped. Removed the mdx-code-block fence and the Crowdin comment above it — the paragraph is plain prose now.

mintlify broken-links is still green and the orphan count is unchanged at 20.

GigaHierz and others added 2 commits August 28, 2026 13:56
…arity (#2255)

thirdweb was documented across seven pages — a group of three under Dev
Environments, an SDK page under Libraries & SDKs, and three orphaned pages
under build-on-celo/ — with tutorials, step-by-step code, and "recommended"
wording that no other tool in the docs gets.

It is now one page, `tooling/dev-environments/thirdweb`, flat alongside
foundry, hardhat and remix: what it is, the Celo chain configuration, and a
link to thirdweb's own docs. All six other paths redirect there.

Also in this change:

- Removes the tutorials (NFT drop, one-click quickstart) and the CLI/SDK
  walkthroughs — thirdweb's own docs cover them.
- Wallet-provider entry in tooling/wallets/index kept as a plain list item at
  parity with the other providers; utm campaign parameters dropped there and
  on the nodes page.
- x402 "Alternative: thirdweb facilitator" reduced to one link under a neutral
  "Other facilitators" heading.
- Indexer section of scaling-your-app no longer recommends a vendor; it points
  at the Indexers group.
- Fixes a mislinked wagmi reference in attribution-tags that pointed at the
  thirdweb overview page.
- Updates the two stale "Using ..." lists to current root-relative paths and
  adds the missing Foundry entry.
- Deletes three now-unreferenced thirdweb images.

Clears the three thirdweb orphans; the remaining 20 belong to #2253.

Verified: `mintlify broken-links` reports no broken links;
`scripts/check-orphans.sh` reports 20 orphans, all owned by #2253.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…irect

Review fixes on #2255:

- `thirdweb/chains` does export Celo Sepolia as `celoSepoliaTestnet` (chain ID
  11142220). Verified against thirdweb@5.121.1:
  dist/esm/chains/chain-definitions/celo-sepolia-testnet.js. The page now uses
  the named export for both networks instead of defineChain.
- Adds the `/tooling/libraries-sdks/thirdweb-sdk/index` redirect source.
  Mintlify served the deleted page at that path too, and only the bare path was
  covered.
- Drops the `mdx-code-block` fence in tooling/dev-environments/index.mdx — a
  Docusaurus/Crowdin leftover that Mintlify renders as a literal code block.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@palango
palango merged commit 301a0e3 into main Aug 28, 2026
4 checks passed
@palango
palango deleted the GigaHierz/2255-thirdweb-one-page branch August 28, 2026 14:41
GigaHierz added a commit that referenced this pull request Aug 31, 2026
…fixes, gate coverage

Review fixes on #2253.

Redirects. Mintlify takes one hop, and array order decides which entry matches,
so a specific source below a wildcard is dead code. Six legacy URLs reached a
page this PR deletes and would have 404d; three more were a regression from
#2291, where /build/:slug* shadowed the thirdweb entries. Explicit entries for
all of them now sit above the wildcards, along with the /developer/setup/* and
/developer/migrate/from-ethereum paths that the segment-dropping wildcards never
resolved. A resolver over the full array now reports zero chains, zero dead
destinations and zero shadowed sources.

Three redirect targets did not answer the deleted page's question: coinbase-wallet
now goes to the MetaMask setup page that carries the same wallet_addEthereumChain
content, setup/wallet to add-celo-testnet-to-metamask, and setup/replit to Remix,
the surviving browser-only path. With socialconnect in navigation, the six
identity-concept sources that pointed at the ContractKit ODIS API page now reach
it, and the celo-for-eth-devs sources reach from-ethereum.

Content on the pages this PR publishes:

- from-ethereum said Celo "uses EigenLayer as the data settlement layer" (it is
  EigenDA, for data availability), claimed 1-second finality, had a reversed
  markdown link to a path that does not resolve, recommended the archived
  celo-org/rosetta, and linked precompiles at celo-blockchain v1.3.2. The
  precompile list now points at core/vm/celo_contracts.go in op-geth.
- migrating-to-viem shipped code that cannot run: an unterminated string literal
  in two blocks, publicClient.getAddresses(), walletClient.sendSignedTransaction,
  and sendTransaction after simulateContract. The CeloTokens helper returned
  pairs, so indexing it by name never worked; it now returns a lookup. The
  Alfajores USDm address was passed as feeCurrency on a mainnet client —
  eth_call symbol() at that address on forno.celo.org returns no code. Replaced
  with the mainnet USDm address, verified to return "USDm".
- hardhat's prerequisites dead-ended: the config needs a mnemonic on Celo's
  derivation path and no page explained how to get one. Now links celocli
  account:new and notes MetaMask cannot produce one.
- contract-verification lost a duplicated lede, gained Foundry in its method
  list, and no longer promises a foundry.toml block that does not exist.
- socialconnect lost its emoji headings, its question heading and "Further
  Reading", and gained a Related section — it had no internal links at all.
- wit-oracle's Solidity blocks were tagged javascript, and the web3.py snippet
  parsed in neither language.
- build-on-celo/index no longer points at an "Edit this page" control; docs.json
  has no feedback key, so it does not render.

The orphan gate had two blind spots that became load-bearing once it fails CI:
pages referenced by href or root were invisible to it, and .md was not matched
at all. Both fixed, with tests confirming an orphaned .md is caught and an
href-only reference is not a false positive.

Deletes img/doc-images/deploy-replit and img/doc-images/testnet-wallet — 18
files, 7.9 MB, unreferenced once replit.mdx and wallet.mdx are gone.

Verified: scripts/check-orphans.sh reports no orphan pages; mintlify
broken-links reports no broken links.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants